RFR: 8283723: Update Visual Studio 2022 to version 17.1.0 for Oracle builds on Windows

[Magnus Ihse Bursie]

On Sun, 27 Mar 2022 05:08:52 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

> Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.1.0.
> 
> This change adds support for building devkits based on VS 2022. Instead of creating a new script file for that I decided to combine it with the logic in createWindowsDevkit2019.sh and rename the resulting file. I decided to dropped support for VS 2017 since that version is pretty old now, let me know if you'd prefer to see it kept around.
> 
> Testing: tier1-5 + additional testing.

make/devkit/createWindowsDevkit.sh line 74:

> 72: # Work around the insanely named ProgramFiles(x86) env variable
> 73: PROGRAMFILES_X86="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set | sed -n 's/^ProgramFiles(x86)=//p' | tr -d '\r')")"
> 74: PROGRAMFILES="$($WINDOWS_PATH_TO_UNIX_PATH "$(cmd.exe /c set | sed -n 's/^PROGRAMFILES=//p' | tr -d '\r')")"

This complex dance isn't necessary; it's a special operation for just the "ProgramFiles(x86)" variable, since cygwin can't handle environment variables with `()` in the name. (See the comment above as well)

I think you will be able to access it with just a simple `$PROGRAMFILES`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7974