VS2017 build errors jdk/jdk

[erik.joelsson at oracle.com]

On 2022-05-10 04:52, Baesken, Matthias wrote:
>> So maybe it time to look at it, it might be easier to have a smaller set
>> of VS releases to support.

Because of how much specific logic we need in configure for each version 
of Visual Studio, we have generally kept configure support for older 
versions of VS for a long time, to not unnecessarily limit people. We 
removed 2015 and older when we moved to C++11 in Hotspot as 2017 or 
later was a hard requirement.

Which compiler versions actually work depends on if anyone wants to keep 
up with the maintenance to keep them working. If VS2017 becomes unusable 
and nobody wants or is able to fix it, then I agree that we should 
remove support from configure.

> On the other hand,  having VS2017 for JDK11 - head  is rather nice for  backporting .

Visual Studio allows side by side installations of multiple major 
versions. The OpenJDK configure script will pick one by default based on 
what's available, but you can also direct it with the parameter 
--with-toolchain-version=[2019|2017|2022].

/Erik

> Best regards, Matthias
>
>
>
> -----Original Message-----
> From: Alan Bateman <Alan.Bateman at oracle.com>
> Sent: Tuesday, 10 May 2022 13:16
> To: Baesken, Matthias <matthias.baesken at sap.com>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>
> Cc: Zeller, Arno <arno.zeller at sap.com>
> Subject: Re: VS2017 build errors jdk/jdk
>
> On 10/05/2022 09:29, Baesken, Matthias wrote:
>> Hello, it seems jdk/jdk does not build any more with VS2017.
>> Should we still support this compiler ?
>>
>> For the error see :
>>
>> https://bugs.openjdk.java.net/browse/JDK-8286459
>> 8286459: compile error with VS2017 in continuationFreezeThaw.cpp
>>
> In Oracle, we moved from using VS2019 16.9.3 to VS2022 17.1.0 a few
> months ago.
>
> I checked the Microsoft site to get the status of VS2017. It says that
> the "Mainstream End Date" for that release was April 2022 so I guess
> it's not easy to get updates without extended support now.
>
> So maybe it time to look at it, it might be easier to have a smaller set
> of VS releases to support.
>
> -Alan