RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled

[Jaikiran Pai]

On Wed, 11 May 2022 11:56:30 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Can I please get a review of this change which fixes build failures on macos when using `--with-zlib=bundled`?
>> 
>> With this change the build now passes (tested both with bundled and system zlib variants).
>> 
>> tier1, tier2 and tier3 testing has been done and no related failures have been noticed.
>
> src/java.base/share/native/libzip/zlib/gzwrite.c line 452:
> 
>> 450:     len = strlen(next);
>> 451: #  else
>> 452: #   ifdef __APPLE__ // ignore format-nonliteral warning on macOS
> 
> Instead of patching 3rd party code to fix a compilation warning, you should disable that warning instead.
> 
> In `make/modules/java.base/lib/CoreLibraries.gmk`, add 
> 
> DISABLED_WARNINGS_clang := format-nonliteral, \
> 
> as line 138.

Thank you for these useful inputs Magnus. I did these changes locally but for some reason this format-nonliteral is not getting picked up while building that library. I will investigate and see what's going on. Will update the PR once I figure it out.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8651