RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

Jaikiran Pai jpai at openjdk.java.net
Wed May 11 14:24:38 UTC 2022


> Can I please get a review of this change which fixes build failures on macos when using `--with-zlib=bundled`?
> 
> With this change the build now passes (tested both with bundled and system zlib variants).
> 
> tier1, tier2 and tier3 testing has been done and no related failures have been noticed.

Jaikiran Pai has updated the pull request incrementally with four additional commits since the last revision:

 - copyright years
 - disable format-nonliteral warning when building LIBSPLASHSCREEN with bundled zlib
 - Magnus' suggestion - make the LIBZ_CFLAGS more readable in the build file
 - Magnus' suggestion - Disable format-nonliteral in build section of zlib instead of source code

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8651/files
  - new: https://git.openjdk.java.net/jdk/pull/8651/files/eee12c25..081a7d34

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8651&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8651&range=00-01

  Stats: 41 lines in 5 files changed: 5 ins; 30 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8651.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8651/head:pull/8651

PR: https://git.openjdk.java.net/jdk/pull/8651



More information about the build-dev mailing list