RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

[Lance Andersen]

On Wed, 11 May 2022 14:25:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> I agree with Magnus and try to avoid changing the imported zlib code.
>
>>  I did these changes locally but for some reason this format-nonliteral is not getting picked up while building that library.
> 
> Turns out that was slightly inaccurate. What was actually happening was that, that setting you suggested in that build file did indeed work and got picked up. But it ran into an error which looked like:
> 
> 
> src/java.base/share/native/libzip/zlib/gzwrite.c:452:40: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
>     len = vsnprintf(next, state->size, format, va);
>                                        ^~~~~~

> I agree with Magnus and try to avoid changing the imported zlib code.

We already had modified gzwrite.c in our port so I thought keeping the changes narrowed to apple made sense here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8651