RFR: 8286562: GCC 12 reports some compiler warnings [v2]
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Thu May 12 01:27:30 UTC 2022
On Wed, 11 May 2022 13:47:43 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c line 193:
>
>> 191: #if defined(__GNUC__) && __GNUC__ >= 12
>> 192: #pragma GCC diagnostic pop
>> 193: #endif
>
> Rather than all this warning suppression cruft and the comment explaining why
> it's okay, just compute the `(strBufNextChar - strBufBegin)` offset a few
> lines earlier, before the realloc.
I did do that in new commit, and the warning has gone!
-------------
PR: https://git.openjdk.java.net/jdk/pull/8646
More information about the build-dev
mailing list