RFR: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled [v2]

[Jaikiran Pai]

On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which fixes build failures on macos when using `--with-zlib=bundled`?
>> 
>> With this change the build now passes (tested both with bundled and system zlib variants).
>> 
>> tier1, tier2 and tier3 testing has been done and no related failures have been noticed.
>
> Jaikiran Pai has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - copyright years
>  - disable format-nonliteral warning when building LIBSPLASHSCREEN with bundled zlib
>  - Magnus' suggestion - make the LIBZ_CFLAGS more readable in the build file
>  - Magnus' suggestion - Disable format-nonliteral in build section of zlib instead of source code

Thank you Lance and Magnus for the reviews and inputs. I've triggered various build and test runs with this state of the PR. Once those complete satisfactorily, I'll go ahead and integrate this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8651