RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v45]

Uwe Schindler uschindler at openjdk.java.net
Fri May 13 08:37:18 UTC 2022


On Fri, 13 May 2022 08:25:01 GMT, Uwe Schindler <uschindler at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 65 commits:
>> 
>>  - Merge branch 'master' into foreign-preview
>>  - Merge branch 'master' into foreign-preview
>>  - Fix crashes in heap segment benchmarks due to misaligned access
>>  - Merge branch 'master' into foreign-preview
>>  - Update src/java.base/share/classes/jdk/internal/reflect/Reflection.java
>>    
>>    Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
>>  - Add tests for loaderLookup/restricted method corner cases
>>  - * Clarify what happens when SymbolLookup::loaderLookup is invoked from JNI
>>    * Tweak restricted method check to work when there's no caller class
>>  - Tweak examples in SymbolLookup javadoc
>>  - Merge branch 'master' into foreign-preview
>>  - Update src/java.base/share/classes/jdk/internal/misc/X-ScopedMemoryAccess.java.template
>>    
>>    Co-authored-by: ExE Boss <3889017+ExE-Boss at users.noreply.github.com>
>>  - ... and 55 more: https://git.openjdk.java.net/jdk/compare/82aa0455...f170415b
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 1045:
> 
>> 1043:      *
>> 1044:      * @throws UnsupportedOperationException
>> 1045:      *         If an unsupported map mode is specified.
> 
> I think this should mention that UOE is also throws if the filesystem implementation does not support memory mapping. This may happen for filesystems like jrtfs or custom wrapper filesystems that do not implement the method below.
> 
> As this is already merged, should I open a PR fixing the docs or open an issue?

This change here also closes [JDK-8259034](https://bugs.openjdk.java.net/browse/JDK-8259034)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7888



More information about the build-dev mailing list