RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]
Leonid Mesnik
lmesnik at openjdk.java.net
Mon May 16 22:09:33 UTC 2022
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which proposes to fix the failure handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission error. The commit in this PR uses `sudo` as suggested in the man pages of that command.
>>
>> Tested locally on macOS by running:
>>
>>
>> cd test/failure_handler
>> make clean
>> make test
>>
>> Then checked the generated environment.html files for the dmesg command output. Looks fine after this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> copyright year
Looks reasonable.
-------------
Marked as reviewed by lmesnik (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8703
More information about the build-dev
mailing list