RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v6]

[Thomas Stuefe]

On Sat, 2 Apr 2022 05:54:16 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 58 commits:
>> 
>>  - Apply remaining review comments from Thomas Stuefe
>>  - Change load_dwarf_file with DwarfFilePath and DebugInfo
>>  - Revert renaming on Windows
>>  - Merge branch 'master' into JDK-8242181
>>  - Updating some comments
>>  - Cleanup loading dwarf file and add summary
>>  - Review comments of first pass by Thomas except dwarf file loading
>>  - Merge branch 'master' into JDK-8242181
>>  - Make dwarf tag NOT_PRODUCT
>>  - Change log_* to log_develop_* and log_warning to log_develop_info
>>  - ... and 48 more: https://git.openjdk.java.net/jdk/compare/c2c0cb2a...06489da2
>
> Hi Christian, I won't have time to look at this closely again until end of next week. At first glance it looks a lot better now, thanks for taking my suggestions. 
> 
>> Should we generally use assertions inside this error reporting code? For now, I've just went with bailouts without any assertions to avoid a corrupted stack/hs_err_file.
> 
> Assertions will be handled like secondary crashes and show up as "error occurred during error reporting" with, I believe, file/line of the assertion. If that makes sense, that's fine. It helps finding bugs in stack printing code, and if you would crash anyway if you continue, an assertion is ok I think.
> 
> Cheers, Thomas

> @tstuefe: Is this still an issue with the latest commit which added -gdwarf-4?

Issues seem to have disappeared. I'll schedule some more tests next week to be sure.

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/7126