RFR: 8295653: Add a graph of the sealed class hierarchy for marked classes [v4]

[Magnus Ihse Bursie]

On Sat, 29 Oct 2022 00:13:05 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename sealedGraphDotPath to sealedDotOutputDir
>
> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 106:
> 
>> 104:         } catch (FileNotFoundException e) {
>> 105:             throw new RuntimeException(e);
>> 106:         }
> 
> It's certainly unusual for a taglet `.toString` call to have this sort of side effect.   It would not the a showstopper, but have you checked whether this code is just executed once or multiple times?

This is Per's code; I didn't look in detail in it. It does seem to be the correct place, though; it's more like the name of the method is bad, since it overloads the `toString` from `Object`, and gives the wrong impressions of its meaning and usage.

However, it seems we need change some code to be guaranteed by called only once. Looking into it...

-------------

PR: https://git.openjdk.org/jdk/pull/10761