RFR: 8295812: Skip the "half float" support in LittleCMS during the build [v2]

Sergey Bylokhov serb at openjdk.org
Sat Nov 5 04:56:42 UTC 2022


> The Java2d do not use "half" float in the image layouts, so we can disable it in the LittleCMS library during the build. It is possible to do using [this](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/liblcms/lcms2.h#L85) public option:
> 
> 
> // Uncomment to get rid of the tables for "half" float support
> // #define CMS_NO_HALF_SUPPORT 1
> 
> 
> This change cuts not only the unused by java2d functions but also [such](https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.desktop/share/native/liblcms/cmshalf.c#L63) tables.
> 
> The size of liblcms decreased by 20 kB on Linux(536024 vs 515152) and 15 kB on windows(246784 vs 231424). On macOS the  win is only 300 bytes.

Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into JDK-8295812
 - 8295812: Skip the "half float" support in LittleCMS during the build

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10830/files
  - new: https://git.openjdk.org/jdk/pull/10830/files/2b66abd4..cb694af2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10830&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10830&range=00-01

  Stats: 180880 lines in 1463 files changed: 88306 ins; 60595 del; 31979 mod
  Patch: https://git.openjdk.org/jdk/pull/10830.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10830/head:pull/10830

PR: https://git.openjdk.org/jdk/pull/10830



More information about the build-dev mailing list