RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v2]

Julian Waters jwaters at openjdk.org
Tue Nov 15 16:04:10 UTC 2022


On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available when both 8282948 and 8282700 were written. They can now be moved to using the cleaner logic that UTIL_ARG_WITH grants.
>> 
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4. They are out of the scope of this commit, which aims only to rework the previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into util
>  - Squash

Oh, silly me, you mean with the options passed

(Arbitrary values passed because I can't think of unique names)

bash configure --with-toolchain-type=gcc --build=x86_64-pc-msys --openjdk-target=x86_64-pc-msys --without-version-opt --with-jtreg=/d/Eclipse/jtreg --with-build-user=UCRT64 --with-macosx-bundle-name-base=Java --enable-linktime-gc --enable-jvm-feature-link-time-opt


`MACOSX_BUNDLE_NAME_BASE=Java`

I'm not confident enough to integrate yet though, since I'm fairly certain COMPANY_NAME isn't working due to a deeper and potentially more serious underlying problem

-------------

PR: https://git.openjdk.org/jdk/pull/11020



More information about the build-dev mailing list