RFR: JDK-8286666: JEP 429: Implementation of Scoped Values (Incubator) [v6]

[Andrew Haley]

On Tue, 15 Nov 2022 18:35:06 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix failing serviceability tests
>
> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java line 172:
> 
>> 170:  * must be an integer power of 2.
>> 171:  *
>> 172:  * <p>For example, you could use {@code -Djdk.incubator.concurrent.ScopedValue.cacheSize=8}.
> 
> I would also avoid "you" and "we" in the javadoc. While javadoc is not formal, we often use locutions such as "clients can use/do XYZ".

OK, it's a style thing. Wilco.

> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java line 185:
> 
>> 183:  * would have to be regenerated after a blocking operation.
>> 184:  *
>> 185:  * @param <T> the type of the value
> 
> Suggestion:
> 
>  * @param <T> the type of the scoped value

Mm, but this is the type of the value of the `ScopedValue` instance.
So, the type of the scoped value is `ScopedValue<T>`, the type of the value is `T`, is it not?

-------------

PR: https://git.openjdk.org/jdk/pull/10952