RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v2]

[Magnus Ihse Bursie]

On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available when both 8282948 and 8282700 were written. They can now be moved to using the cleaner logic that UTIL_ARG_WITH grants.
>> 
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4. They are out of the scope of this commit, which aims only to rework the previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into util
>  - Squash

make/autoconf/jdk-version.m4 line 82:

> 80:   UTIL_ARG_WITH(NAME: build-user, TYPE: string,
> 81:     RESULT: USERNAME,
> 82:     DEFAULT: $USERNAME,

This looks like the same values flow in and out of the function. Maybe call the fallback value `DEFAULT_USERNAME`?

make/autoconf/jdk-version.m4 line 84:

> 82:     DEFAULT: $USERNAME,
> 83:     DESC: [build username to use in version strings],
> 84:     IF_GIVEN: [

In general, I think these tests would be better expressed using the `CHECK_VALUE` construct, rather than `IF_GIVEN`. (A more specific reason is better than a vaguer and more general)

-------------

PR: https://git.openjdk.org/jdk/pull/11020