RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v2]
Julian Waters
jwaters at openjdk.org
Thu Nov 17 04:39:14 UTC 2022
On Thu, 17 Nov 2022 03:56:44 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> make/autoconf/jdk-version.m4 line 95:
>>
>>> 93: UTIL_ARG_WITH(NAME: jdk-rc-name, TYPE: string,
>>> 94: DEFAULT: [$PRODUCT_NAME $JDK_RC_PLATFORM_NAME],
>>> 95: DESC: [Set JDK RC name. This is used for FileDescription and ProductName
>>
>> Please use `DEFAULT_DESC` instead of the old `@<:@...@:>@` construct. (This too goes for all the instances)
>
> Embarrassingly I left it that way since I didn't know what `@<:@...@:>@` actually did. So the following replacement should work?
>
> DEFAULT_DESC: [Set JDK RC name. This is used for FileDescription and ProductName properties of MS Windows binaries.]
I've changed them accordingly to what should be right, do let me know if I've made any mistakes in my usage of `DEFAULT_DESC`
-------------
PR: https://git.openjdk.org/jdk/pull/11020
More information about the build-dev
mailing list