RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v2]

Julian Waters jwaters at openjdk.org
Thu Nov 17 06:36:53 UTC 2022


On Wed, 16 Nov 2022 19:33:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into util
>>  - Squash
>
> make/autoconf/jdk-version.m4 line 82:
> 
>> 80:   UTIL_ARG_WITH(NAME: build-user, TYPE: string,
>> 81:     RESULT: USERNAME,
>> 82:     DEFAULT: $USERNAME,
> 
> This looks like the same values flow in and out of the function. Maybe call the fallback value `DEFAULT_USERNAME`?

Resolved, thanks

-------------

PR: https://git.openjdk.org/jdk/pull/11020



More information about the build-dev mailing list