RFR: 8296904: Improve handling of macos xcode toolchain [v8]

[Christoph Langer]

On Fri, 18 Nov 2022 12:06:39 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> With this PR I'd like to make it easier to use dedicated installations of Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode globally via `xcode-select`.
>> 
>> I propose adding a new configure flag `--with-xcode-path` that takes the path to an Xcode installation. If the option is set, this path is expanded to a valid `TOOLCHAIN_PATH`.
>> 
>> Furthermore, I fix detection of xcodebuild and correctly setting the sysroot from the toolchain by moving `AC_SUBST(TOOLCHAIN_PATH)` before calling `BASIC_SETUP_XCODE_SYSROOT` and honoring `TOOLCHAIN_PATH` in `BASIC_SETUP_XCODE_SYSROOT` in the case when no devkit is specified. As I see it, this is a viable fix, even if not introducing `--with-xcode-path`.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix enumeration for html

> It is generated, and you can re-generate it using `make update-build-docs`. However, you need to have the same version of pandoc installed and configured, otherwise you'll get a lot of spurious changes.
> 
> To help you out, I checked out your branch and regenerated it for you. You can find it at [66ef4b7](https://github.com/openjdk/jdk/commit/66ef4b730656daeb4108f7118b92dea3e8da6475) (from https://github.com/magicus/jdk/tree/xcode-toolchain). If you are not a git wrangling pro, you can download it as a diff and apply it locally by appending `.diff`: https://github.com/openjdk/jdk/commit/66ef4b730656daeb4108f7118b92dea3e8da6475.diff

Woho, [66ef4b7] is a super power trick 😄 I've added it and then figured out that my new enumeration isn't displayed well in html. Can you please regnerate it once more?

Other than that, are my edits ok?

-------------

PR: https://git.openjdk.org/jdk/pull/11113