RFR: 8293422: DWARF emitted by Clang cannot be parsed [v4]

Christian Hagedorn chagedorn at openjdk.org
Fri Nov 18 16:01:44 UTC 2022


On Wed, 16 Nov 2022 16:07:36 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> In theory, they don't need to be exposed in the sense of being declared in the header. But in terms of readability, I've decided to put them in the private block of class `LineNumberProgram` which is the only user of these methods. What would be the advantages of moving them completely to `elfFile.cpp` as static helper functions?
>
> Oh, I generally just prefer to keep things locally if possible. Slim interfaces, less polluted global namespace, possibly (though not here) less include deps. Don't worry, if you prefer it this way, keep it in.

I understand. I don't have a strong preference here but to be consistent with the existing DWARF parser code, I'd rather keep it like that.

-------------

PR: https://git.openjdk.org/jdk/pull/10287



More information about the build-dev mailing list