RFR: 8297342: make LOG=debug is too verbose

[Magnus Ihse Bursie]

On Mon, 21 Nov 2022 14:11:27 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The `debug` level of make logging is not really useful, since it spits out a full expansion of all named param macro arguments and their values. 
> 
> With the NamedParamsMacroTemplate being stable for years, this is seldom useful, and the massive amount of logs drown out everything else.
> 
> We should move this debugging to the `trace` level.

Without this fix, all debug logs would start by a massive amount of 

Building target 'jdk' in configuration 'macosx-aarch64'
make[2]: Entering directory '/Users/ihse/git/jdk-DOH/open'
SetupTarget buildtools-langtools  
 [2] MAKEFILE := ToolsLangtools                                                                                                                                                                                            
SetupTarget interim-langtools  
 [2] MAKEFILE := CompileInterimLangtools                                                                                                                                                                                            
SetupTarget interim-tzdb  
 [2] MAKEFILE := CopyInterimTZDB                                                                                                                                                                                            
SetupTarget buildtools-jdk  
 [2] MAKEFILE := CompileToolsJdk  
 [3] DEPS := interim-langtools interim-tzdb                                                                                                                                                                                          
SetupTarget buildtools-modules  
 [2] MAKEFILE := CompileModuleTools                                                                                                                                                                                            
SetupTarget buildtools-hotspot  
 [2] MAKEFILE := CompileToolsHotspot             


listing all make targets from Main.gmk.

With this fix, the log starts

Building target 'jdk' in configuration 'macosx-aarch64-server-release'
gmake[2]: Entering directory '/Users/ihse/git/jdk-DOH/open'
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ToolsLangtools.gmk  )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f CopyInterimTZDB.gmk  )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/java.base MODULE=java.base MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f CompileToolsHotspot.gmk  )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/java.desktop MODULE=java.desktop MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/java.logging MODULE=java.logging MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/jdk.accessibility MODULE=jdk.accessibility MAKEFILE_PREFIX=Copy )
(cd /Users/ihse/git/jdk-DOH/open/make && /opt/homebrew/bin/gmake  -r -R -I /Users/ihse/git/jdk-DOH/open/make/common SPEC=/Users/ihse/git/jdk-DOH/open/build/macosx-aarch64-server-release/spec.gmk MAKE_LOG_FLAGS=""  -f ModuleWrapper.gmk -I /Users/ihse/git/jdk-DOH/open/make/common/modules -I/Users/ihse/git/jdk-DOH/open/make/modules/jdk.management.agent MODULE=jdk.management.agent MAKEFILE_PREFIX=Copy )
gmake[3]: Entering directory '/Users/ihse/git/jdk-DOH/open/make'


which is much more helpful in showing how the build system starts collecting initial dependencies.

-------------

PR: https://git.openjdk.org/jdk/pull/11264