RFR: 8296904: Improve handling of macos xcode toolchain [v10]

Christoph Langer clanger at openjdk.org
Tue Nov 22 21:02:58 UTC 2022


> With this PR I'd like to make it easier to use dedicated installations of Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode globally via `xcode-select`.
> 
> I propose adding a new configure flag `--with-xcode-path` that takes the path to an Xcode installation. If the option is set, this path is expanded to a valid `TOOLCHAIN_PATH`.
> 
> Furthermore, I fix detection of xcodebuild and correctly setting the sysroot from the toolchain by moving `AC_SUBST(TOOLCHAIN_PATH)` before calling `BASIC_SETUP_XCODE_SYSROOT` and honoring `TOOLCHAIN_PATH` in `BASIC_SETUP_XCODE_SYSROOT` in the case when no devkit is specified. As I see it, this is a viable fix, even if not introducing `--with-xcode-path`.

Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:

  Regenerate once more

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11113/files
  - new: https://git.openjdk.org/jdk/pull/11113/files/2a5e4e44..733c300f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11113&range=09
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11113&range=08-09

  Stats: 22 lines in 1 file changed: 17 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/11113.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11113/head:pull/11113

PR: https://git.openjdk.org/jdk/pull/11113



More information about the build-dev mailing list