Integrated: 8296904: Improve handling of macos xcode toolchain

[Christoph Langer]

On Fri, 11 Nov 2022 22:22:51 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> With this PR I'd like to make it easier to use dedicated installations of Xcode on Mac OS for OpenJDK builds without having to switch the active Xcode globally via `xcode-select`.
> 
> I propose adding a new configure flag `--with-xcode-path` that takes the path to an Xcode installation. If the option is set, this path is expanded to a valid `TOOLCHAIN_PATH`.
> 
> Furthermore, I fix detection of xcodebuild and correctly setting the sysroot from the toolchain by moving `AC_SUBST(TOOLCHAIN_PATH)` before calling `BASIC_SETUP_XCODE_SYSROOT` and honoring `TOOLCHAIN_PATH` in `BASIC_SETUP_XCODE_SYSROOT` in the case when no devkit is specified. As I see it, this is a viable fix, even if not introducing `--with-xcode-path`.

This pull request has now been integrated.

Changeset: 470f3424
Author:    Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/470f3424fcce0e41b75cccdd5e3a56771cd07ff5
Stats:     85 lines in 3 files changed: 31 ins; 5 del; 49 mod

8296904: Improve handling of macos xcode toolchain

Reviewed-by: erikj, ihse

-------------

PR: https://git.openjdk.org/jdk/pull/11113