RFR: 8294456: Fix misleading-indentation warnings in JDK [v2]

Aleksey Shipilev shade at openjdk.org
Wed Oct 5 10:20:33 UTC 2022


On Wed, 5 Oct 2022 10:02:49 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> This fixes misleading indentations, which allows enabling the (currently disabled) `misleading-indentation` warning flag on two `.gmk` files.
>
> Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - 8294456: Fix misleading-indentation warnings in JDK
>    
>    Merge branch 'master' into JDK-8294456
>  - 8294456: Fix misleading-indentation warnings in JDK

make/modules/java.desktop/lib/Awt2dLibraries.gmk line 298:

> 296:     HEADERS_FROM_SRC := $(LIBLCMS_HEADERS_FROM_SRC), \
> 297:     DISABLED_WARNINGS_gcc := format-nonliteral type-limits \
> 298:         undef unused-function stringop-truncation, \

Ok, let's not touch this global warning and rename the issue to "Fix misleading-indentation warnings in core JDK libraries". Leave the Awt2d change to another day.

-------------

PR: https://git.openjdk.org/jdk/pull/10487



More information about the build-dev mailing list