Integrated: 8294310: compare.sh fails on macos after JDK-8293550

Erik Joelsson erikj at openjdk.org
Wed Oct 5 12:46:31 UTC 2022


On Mon, 26 Sep 2022 22:51:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Since [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) we are adding adhoc signatures to all binaries on macos, and the compare script is no longer running cleanly. In order to compare binaries on macos, especially on aarch64, where signatures are mandatory, we will have to remove them first. They will never be exactly the same between two runs.
> 
> This patch adds `codesign --remove-signature` to compare.sh before comparing any executables or libraries. Stripping the signature has to happen after running `strip` as strip will fail otherwise. I also had to add a special option to strip to avoid warnings.
> 
> While enabling baseline compare runs for macosx-aarch64 in our CI, I discovered that were also not running testmake for aarch64, so I snuck in that change in jib-profiles.js here as well.

This pull request has now been integrated.

Changeset: b9eeec2b
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b9eeec2b6b8f97d2ba33462b27d091f918067f78
Stats:     14 lines in 3 files changed: 10 ins; 0 del; 4 mod

8294310: compare.sh fails on macos after JDK-8293550

Reviewed-by: ihse

-------------

PR: https://git.openjdk.org/jdk/pull/10435



More information about the build-dev mailing list