RFR: 8294594: Fix cast-function-type warnings in signal handling code [v2]

Aleksey Shipilev shade at openjdk.org
Tue Oct 11 08:40:24 UTC 2022


On Tue, 11 Oct 2022 08:28:48 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> For POSIX we expect the handler argument for os::signal to be a sigaction handler (taking 3 arguments). For Windows we expect os::signal to take a 1 argument handler, since Windows seemingly doesn't support the sigaction stuff. How is that a portability layer?

D'oh.

> That all seems to me like it would be better to separate from this change, keeping this one nice and simple.

Agreed.

-------------

PR: https://git.openjdk.org/jdk/pull/10494



More information about the build-dev mailing list