RFR: 8295070: Introduce more target combinations for compiler flags [v3]

[Magnus Ihse Bursie]

On Mon, 10 Oct 2022 15:29:16 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several parts of the make system in the JDK has large parts of cluttered if branches dedicated to setting flags for the specific compiler used in the build. This could be more neatly accomplished by instead adding more target combinations in SetupNativeCompilation so the callsite can more cleanly specify which OS and compiler it desires to set these flags for. The change currently includes:
>> 
>> DISABLED_WARNINGS (including per file warnings), CFLAGS/CXXFLAGS and LDFLAGS: Compiler-then-OS (The priority shown reflects how the flags depend more so on the compiler)
>> LIBS: OS-then-Compiler, as libraries typically vary based on the system being compiled for
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Extra spacing

I can't see anything inherently wrong in the patch, but every extra combination adds extra complexity. 

I just would like to see some concrete examples of where these new additions would help, so we're not just pouring in additional combinations "just for the sake of it".

-------------

PR: https://git.openjdk.org/jdk/pull/10634