RFR: 8294314: Minimize disabled warnings in hotspot [v21]

Wed Oct 12 13:45:14 UTC 2022

On Wed, 12 Oct 2022 13:33:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Github workflow changes were not supposed to be in this PR...
>
> make/hotspot/lib/CompileJvm.gmk line 92:
> 
>> 90: 
>> 91: DISABLED_WARNINGS_clang := ignored-qualifiers sometimes-uninitialized \
>> 92:     missing-braces delete-non-abstract-non-virtual-dtor unknown-pragmas
> 
> Shouldn't shift-negative-value be in the clang list too?

Well, there is currently no instance of clang complaining about this. This could be due to:

* This warning does not really exist on clang
* Or it is not enabled by our current clang flags
* Or the code which triggers the warning in gcc is not reached by clang
* Or clang is smarter than gcc and can determine that the usage is ok after all
* Or clang is dumber than gcc and does not even see that there could have been a problem...

...

I'm kind of reluctant to add warnings to this list that have not occurred for real. My suggestion is that we add it here if we ever see it making incorrect claims. Ok?

-------------

PR: https://git.openjdk.org/jdk/pull/10414