RFR: 8295229: Try to verify gtest version [v2]

John R Rose jrose at openjdk.org
Thu Oct 13 05:13:12 UTC 2022


On Thu, 13 Oct 2022 02:56:01 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge branch 'master' into try-verify-gtest-version
>>  - 8295229: Try to verify gtest version
>
> @magicus I truly appreciate your timely help!
> It will be a convenient move for new developers.

Looks good.  I guess we will have to find out be experience how fragile or robust are these new tests.  Thank you for cross-linking from testing.md to building.md.  I remember when I first worked with gtest the information was split between the two files, but not cross-linked, and I found it confusing to put the pieces together myself.  This makes learning gtest on hotspot easier for the next person, as @DingliZhang says.

-------------

PR: https://git.openjdk.org/jdk/pull/10677



More information about the build-dev mailing list