RFR: 8295231: Move all linking of native libraries to make [v3]

Julian Waters jwaters at openjdk.org
Mon Oct 17 14:27:32 UTC 2022


On Sun, 16 Oct 2022 13:18:14 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update Guid.cpp
>
> src/java.base/windows/native/libnio/ch/FileDispatcherImpl.c line 38:
> 
>> 36: 
>> 37: #include <Mswsock.h>
>> 38: #pragma comment(lib, "Mswsock.lib")
> 
> I think this came about with one of the early Microsoft contributions to have transferTo optionally use TransmitFile on Windows. This created the dependency on Mswsock. It's not clear why a pragma was used though.

I believe it may have had to do with explicitly showing the dependency as David suggests, I added a comment explaining this just in case

-------------

PR: https://git.openjdk.org/jdk/pull/10633



More information about the build-dev mailing list