RFR: 8295231: Move all linking of native libraries to make [v4]

Julian Waters jwaters at openjdk.org
Mon Oct 17 14:31:46 UTC 2022


> Some external libraries required by native code are linked via linker comments embedded in pragmas. Searching for which libraries are linked can then become frustrating and confusing since they may be included in an obscure place, and for all relevant compilers there is no difference between specifying them from make and in a source file. The easiest solution is to just always link them from make and remove any source level linkage.

Julian Waters has updated the pull request incrementally with five additional commits since the last revision:

 - Update WinSysInfo.cpp
 - Update WinApp.cpp
 - Update MsiUtils.cpp
 - Update MsiDb.cpp
 - Update MsiCA.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10633/files
  - new: https://git.openjdk.org/jdk/pull/10633/files/fe15f907..8afaf85d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10633&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10633&range=02-03

  Stats: 12 lines in 5 files changed: 11 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/10633.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10633/head:pull/10633

PR: https://git.openjdk.org/jdk/pull/10633



More information about the build-dev mailing list