RFR: 8294467: Fix sequence-point warnings in Hotspot [v2]
Aleksey Shipilev
shade at openjdk.org
Mon Oct 17 18:21:48 UTC 2022
> There seem to be the only place in Hotspot where this warning fires, yet the warning is disabled wholesale for Hotspot. This is not good.
>
> I can trace the addition of sequence-point exclusion to [JDK-8211029](https://bugs.openjdk.org/browse/JDK-8211029) (Sep 2018), yet the only place where it triggers introduced by [JDK-8259609](https://bugs.openjdk.org/browse/JDK-8259609) (Oct 2021). It seems other places were fixed meanwhile.
>
> I believe the fixed place is just a simple leftover. Right, @rwestrel?
>
> Additional testing:
> - [x] Linux x86_64 fastdebug `tier1`
> - [x] Linux x86_64 fastdebug `tier2`
> - [x] The build matrix of:
> - GCC 10
> - {i686, x86_64, aarch64, powerpc64le, s390x, armhf, riscv64}
> - {server}
> - {release, fastdebug}
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
- Merge branch 'master' into JDK-8294467-warning-sequence-point
- Fix
-------------
Changes: https://git.openjdk.org/jdk/pull/10454/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10454&range=01
Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/10454.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10454/head:pull/10454
PR: https://git.openjdk.org/jdk/pull/10454
More information about the build-dev
mailing list