RFR: 8295715: Minimize disabled warnings in serviceability libs

Chris Plummer cjplummer at openjdk.org
Thu Oct 20 17:56:55 UTC 2022


On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now possible to disable warnings for individual files instead for whole libraries. I used this opportunity to go through all disabled warnings in the serviceability native libraries.
> 
> Any warnings that were only triggered in a few files were removed from the library as a whole, and changed to be only disabled for those files.
> 
> Some warnings didn't trigger in any file anymore, and could just be removed.

Changes look good.

Is there any desire to clean up these warnings? I see back in 2015 there were a bunch of "Resolve disabled warnings for libXXX" bugs that you fixed. Any plans to make another pass. Seems like some of these warnings might be hiding real bugs.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10786



More information about the build-dev mailing list