RFR: 8295990: Improve make handling of strip flags [v2]

Julian Waters jwaters at openjdk.org
Sat Oct 29 07:12:40 UTC 2022


> Strip currently has its flags set by guessing based on the OS, it would be more appropriate to instead set them based on properly checking the strip binary instead of speculating what the correct flags are based on the compiler and OS.

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:

 - Merge branch 'openjdk:master' into patch-1
 - Merge branch 'openjdk:master' into patch-1
 - Add more documentation
 - Replace with the actual new check
 - Little documentation doesn't hurt
 - Prepare for actual changes
 - Update flags-other.m4
 - This is getting annoying
 - -V doesn't work with MacOS strip
 - Get output from strip to search for useful information
 - ... and 3 more: https://git.openjdk.org/jdk/compare/4a1577da...43f615d4

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10882/files
  - new: https://git.openjdk.org/jdk/pull/10882/files/e572f95f..43f615d4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=00-01

  Stats: 69 lines in 8 files changed: 18 ins; 36 del; 15 mod
  Patch: https://git.openjdk.org/jdk/pull/10882.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10882/head:pull/10882

PR: https://git.openjdk.org/jdk/pull/10882



More information about the build-dev mailing list