RFR: 8295990: Improve make handling of strip flags [v3]
Julian Waters
jwaters at openjdk.org
Sat Oct 29 15:33:52 UTC 2022
> Strip currently has its flags set by guessing based on the OS, it would be more appropriate to instead set them based on properly checking the strip binary instead of speculating what the correct flags are based on the compiler and OS.
Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
- Merge branch 'openjdk:master' into patch-1
- Merge branch 'openjdk:master' into patch-1
- Merge branch 'openjdk:master' into patch-1
- Add more documentation
- Replace with the actual new check
- Little documentation doesn't hurt
- Prepare for actual changes
- Update flags-other.m4
- This is getting annoying
- -V doesn't work with MacOS strip
- ... and 4 more: https://git.openjdk.org/jdk/compare/ddcee269...a940c741
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10882/files
- new: https://git.openjdk.org/jdk/pull/10882/files/43f615d4..a940c741
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10882&range=01-02
Stats: 201 lines in 8 files changed: 163 ins; 20 del; 18 mod
Patch: https://git.openjdk.org/jdk/pull/10882.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10882/head:pull/10882
PR: https://git.openjdk.org/jdk/pull/10882
More information about the build-dev
mailing list