RFR: 8295990: Improve make handling of strip flags [v5]

Erik Joelsson erikj at openjdk.org
Mon Oct 31 13:00:34 UTC 2022


On Mon, 31 Oct 2022 06:27:08 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Strip currently has its flags set by guessing based on the OS, it would be more appropriate to instead set them based on properly checking the strip binary instead of speculating what the correct flags are based on the compiler and OS.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-1
>  - Comment can be made more accurate
>  - Merge branch 'openjdk:master' into patch-1
>  - Merge branch 'openjdk:master' into patch-1
>  - Merge branch 'openjdk:master' into patch-1
>  - Add more documentation
>  - Replace with the actual new check
>  - Little documentation doesn't hurt
>  - Prepare for actual changes
>  - Update flags-other.m4
>  - ... and 6 more: https://git.openjdk.org/jdk/compare/028804e4...df46df9d

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/10882



More information about the build-dev mailing list