RFR: 8294549: configure script should detect unsupported path

Mike Duigou mduigou at openjdk.org
Mon Oct 31 19:20:27 UTC 2022


On Thu, 29 Sep 2022 00:09:37 GMT, Mike Duigou <mduigou at openjdk.org> wrote:

> The OpenJDK build system does not support building when the source code resides on a path that contains a space. This requirement is documented in the build instructions but not enforced by the configure script.
> 
> This change adds an explicit checks to the wrapper `configure` script that fail the build if the source code to be built is located in a directory who's path contains a space character or the build path cannot be determined.
> 
> Includes some idiom modernization and shell scripting best practices changes.

My apologies for delay in responding. I had opted to make these changes to this file because I could isolate the changes to a single file. In order to implement the same logic in the "real" configure file at least some changes would be needed to this file in order to correctly pass a path containing spaces. I will look at moving the path check to the real configure file.

-------------

PR: https://git.openjdk.org/jdk/pull/10477



More information about the build-dev mailing list