RFR: 8293293: Move archive heap loading code out of heapShared.cpp

Coleen Phillimore coleenp at openjdk.org
Fri Sep 2 17:20:53 UTC 2022


On Fri, 2 Sep 2022 05:31:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I moved all code related to loading the archive heap regions into a new file, archiveHeapLoader.cpp.
> 
> A diff of the new archiveHeapLoader.cpp and the old heapShared.cpp shows that the moved code is identical, except for the change of `HeapShared::` to `ArchiveHeapLoader::`.
> 
> I also removed unnecessary entries in JVM_EXCLUDE_FILES that are already covered by the `cds/` pattern.

src/hotspot/share/cds/archiveHeapLoader.cpp line 58:

> 56: #include "oops/oop.inline.hpp"
> 57: #include "oops/typeArrayOop.inline.hpp"
> 58: #include "prims/jvmtiExport.hpp"

It looks like you should be able to remove a lot of these header files.

-------------

PR: https://git.openjdk.org/jdk/pull/10138



More information about the build-dev mailing list