RFR: 8293532: Use lighter jmod compression levels in build config [v2]

Aleksey Shipilev shade at openjdk.org
Tue Sep 20 18:57:50 UTC 2022


On Tue, 20 Sep 2022 17:29:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Typos
>>  - GHA should use the zip-1 level across all builds
>>  - Move detection and defaults to configure, select compression based on release/debug
>
> make/autoconf/jdk-options.m4 line 491:
> 
>> 489:   fi
>> 490: 
>> 491:   UTIL_ARG_WITH(NAME: jmod-compress, TYPE: string,
> 
> The `string` type does not check values. I am not at a computer right now so I can check, but I think you need the type called `literal`. Try greping for VALID_VALUES to see other usages.

Indeed, it does not. Changed to `literal`.

-------------

PR: https://git.openjdk.org/jdk/pull/10214



More information about the build-dev mailing list