RFR: 8293887: AArch64 build failure with GCC 12 due to maybe-uninitialized warning in libfdlibm k_rem_pio2.c [v2]
Hao Sun
haosun at openjdk.org
Mon Sep 26 01:42:48 UTC 2022
On Fri, 23 Sep 2022 12:47:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Thanks for your review.
>>
>> Your mentioned solution should work and we can also enable the pragma only for aarch64 + gcc>=12 condition.
>> I considered such a solution when preparing this patch.
>>
>> But I personally prefer to suppress the waring in the makefile, mainly because fdlibm is 3rd party library and we'd better not changing the source code. I think it is a long-standing policy.
>
> Yes, we should not modify 3rd party code.
>
> What you would need is [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281). If you can hold back this patch for a little while, you'll be able to utilize it instead.
Thanks for your info @magicus.
Updated the code using [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281) in the latest commit.
Would you mind taking another look? Thanks! @theRealAph @magicus
-------------
PR: https://git.openjdk.org/jdk/pull/10386
More information about the build-dev
mailing list