RFR: 8294317: Insufficient build rules for tzdb.dat

Erik Joelsson erikj at openjdk.org
Mon Sep 26 12:57:24 UTC 2022


On Fri, 23 Sep 2022 22:10:03 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> The current makefile for `tzdb.dat` won't recompile if some dependent files (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to the dependency will fix this issue.

make/modules/java.base/gendata/GendataTZDB.gmk line 33:

> 31: TZDATA_DIR := $(MODULE_SRC)/share/data/tzdata
> 32: TZDATA_TZFILE := africa antarctica asia australasia europe northamerica southamerica backward etcetera gmt jdk11_backward
> 33: TZDATA_TZFILES := $(TZDATA_DIR)/*

Have you verified that this works? I would expect a wildcard call to be needed. 
Suggestion:

TZDATA_TZFILES := $(wildcard $(TZDATA_DIR)/*)

-------------

PR: https://git.openjdk.org/jdk/pull/10415



More information about the build-dev mailing list