RFR: 8294310: compare.sh fails on macos after JDK-8293550
Erik Joelsson
erikj at openjdk.org
Mon Sep 26 23:00:43 UTC 2022
Since [JDK-8293550](https://bugs.openjdk.org/browse/JDK-8293550) we are adding adhoc signatures to all binaries on macos, and the compare script is no longer running cleanly. In order to compare binaries on macos, especially on aarch64, where signatures are mandatory, we will have to remove them first. They will never be exactly the same between two runs.
This patch adds `codesign --remove-signature` to compare.sh before comparing any executables or libraries. Stripping the signature has to happen after running `strip` as strip will fail otherwise. I also had to add a special option to strip to avoid warnings.
While enabling baseline compare runs for macosx-aarch64 in our CI, I discovered that were also not running testmake for aarch64, so I snuck in that change in jib-profiles.js here as well.
-------------
Commit messages:
- add testmake profile for macosx-aarch64
- JDK-8294310
Changes: https://git.openjdk.org/jdk/pull/10435/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10435&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8294310
Stats: 14 lines in 3 files changed: 10 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/10435.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10435/head:pull/10435
PR: https://git.openjdk.org/jdk/pull/10435
More information about the build-dev
mailing list