RFR: 8294310: compare.sh fails on macos after JDK-8293550
Erik Joelsson
erikj at openjdk.org
Tue Sep 27 12:43:17 UTC 2022
On Tue, 27 Sep 2022 11:28:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> I'm a bit sad to see the exact bit-by-bit comparison on macOS go down the drain. :( Do you think we could export `MACOSX_CODESIGN_MODE` to `compare.sh.in`, and if it is `disabled`, then we do the traditional bit-by-bit comparison? That way we at least have some possible way to do this, even if the signing normally in place makes a complete match impossible.
I know what you mean and I did consider this, but decided against it. On aarch64 there is no way to not get a signed binary and compare.sh was failing even before my codesign change. If you remove the default signature that the linker adds, the OS won't let you start the executable at all. Macos on intel is basically a discontinued platform at this point, so I didn't think it worth the effort to implement and maintain special treatment for it.
-------------
PR: https://git.openjdk.org/jdk/pull/10435
More information about the build-dev
mailing list