RFR: 8294467: Fix sequence-point warnings in Hotspot

Tobias Hartmann thartmann at openjdk.org
Wed Sep 28 06:02:23 UTC 2022


On Tue, 27 Sep 2022 16:34:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> There seem to be the only place in Hotspot where this warning fires, yet the warning is disabled wholesale for Hotspot. This is not good.
> 
> I can trace the addition of sequence-point exclusion to [JDK-8211029](https://bugs.openjdk.org/browse/JDK-8211029) (Sep 2018), yet the only place where it triggers introduced by [JDK-8259609](https://bugs.openjdk.org/browse/JDK-8259609) (Oct 2021). It seems other places were fixed meanwhile.
> 
> I believe the fixed place is just a simple leftover. Right, @rwestrel?
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `tier1`
>  - [x]  Linux x86_64 fastdebug `tier2`
>  - [x] The build matrix of:
>    - GCC 10
>    - {i686, x86_64, aarch64, powerpc64le, s390x, armhf, riscv64}
>    - {server}
>    - {release, fastdebug}

Looks good to me. I'll run this through our testing, just to make sure.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10454



More information about the build-dev mailing list