RFR: 8294314: Minimize disabled warnings in hotspot [v9]

Magnus Ihse Bursie ihse at openjdk.org
Wed Sep 28 07:39:33 UTC 2022


On Wed, 28 Sep 2022 02:41:51 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't need empty-body for ad_ppc.cpp now that it is globally disabled
>
> make/hotspot/lib/CompileJvm.gmk line 162:
> 
>> 160:     DISABLED_WARNINGS_gcc_postaloc.cpp := address, \
>> 161:     DISABLED_WARNINGS_gcc_sharedRuntimeTrig.cpp := misleading-indentation, \
>> 162:     DISABLED_WARNINGS_gcc_shenandoahBarrierSetAssembler_aarch64.cpp := misleading-indentation, \
> 
> Suggestion:
> 
>     DISABLED_WARNINGS_gcc_shenandoahBarrierSet.cpp := misleading-indentation, \
>     DISABLED_WARNINGS_gcc_shenandoahBarrierSetAssembler_aarch64.cpp := misleading-indentation, \
> 
> 
> I got the following warning for `client` build, i.e. `--disable-precompiled-headers --with-debug-level=release --with-jvm-variants=client`.
> 
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-client_libjvm_objs_shenandoahBarrierSet.o:
> In file included from /tmp/jdk-test/jdk_src/src/hotspot/share/gc/shenandoah/henandoahBarrierSet.cpp:34:

Oh, client builds! I forgot about those. Thanks for reminding me. I'll test the full set of JVM variants as well.

-------------

PR: https://git.openjdk.org/jdk/pull/10414



More information about the build-dev mailing list