RFR: 8294438: Fix misleading-indentation warnings in hotspot

Magnus Ihse Bursie ihse at openjdk.org
Wed Sep 28 08:03:21 UTC 2022


On Wed, 28 Sep 2022 06:00:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/classfile/javaClasses.cpp line 3926:
>> 
>>> 3924:   if (k == NULL)  return NULL;
>>> 3925:   InstanceKlass* ik = InstanceKlass::cast(k);
>>> 3926:   if (!ik->is_initialized())  ik->initialize(CHECK_NULL);
>> 
>> That's actually a bug!
>
> How is this a bu... ah. Oh! The second statement from `CHECK_NULL` is effectively out of `if (!ik->is_initialized())` block!

Two, and counting. :-)

-------------

PR: https://git.openjdk.org/jdk/pull/10444



More information about the build-dev mailing list