RFR: 8294549: configure script should detect unsupported path

Mikael Vidstedt mikael at openjdk.org
Thu Sep 29 00:54:07 UTC 2022


On Thu, 29 Sep 2022 00:09:37 GMT, Mike Duigou <mduigou at openjdk.org> wrote:

> The OpenJDK build system does not support building when the source code resides on a path that contains a space. This requirement is documented in the build instructions but not enforced by the configure script.
> 
> This change adds an explicit checks to the wrapper `configure` script that fail the build if the source code to be built is located in a directory who's path contains a space character or the build path cannot be determined.
> 
> Includes some idiom modernization and shell scripting best practices changes.

configure line 29:

> 27: 
> 28: # Get an absolute path to this script, since that determines the top-level directory.
> 29: source_path="${BASH_SOURCE[0]:-$0}"

Can we (do we want to) rely the shell running this script itself supporting BASH_SOURCE and/or other potential bash-isms?

-------------

PR: https://git.openjdk.org/jdk/pull/10477



More information about the build-dev mailing list