RFR: 8294594: Fix cast-function-type warning in signal handling code

David Holmes dholmes at openjdk.org
Fri Sep 30 04:56:33 UTC 2022


On Thu, 29 Sep 2022 16:12:11 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> After [JDK-8294314](https://bugs.openjdk.org/browse/JDK-8294314), we would have signals_posix.cpp excluded with cast-function-type warning:

Marked as reviewed by dholmes (Reviewer).

src/hotspot/os/posix/signals_posix.cpp line 1727:

> 1725:   // Set up signal handler for suspend/resume
> 1726:   act.sa_flags = SA_RESTART|SA_SIGINFO;
> 1727:   act.sa_handler = CAST_FROM_FN_PTR(sa_handler_t, SR_handler);

The underlying cast in the macro seems a little odd for this situation but if it appeases the compiler then that is fine.

-------------

PR: https://git.openjdk.org/jdk/pull/10494



More information about the build-dev mailing list