RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v2]
David Holmes
dholmes at openjdk.org
Mon Apr 3 09:36:41 UTC 2023
On Mon, 3 Apr 2023 07:53:00 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Comment from AlanB
>
> src/java.base/share/classes/java/lang/Thread.java line 231:
>
>> 229: /* Reserved for exclusive use by the JVM. Cannot be moved to FieldHolder
>> 230: as it needs to be set by the VM before executing the constructor that
>> 231: will set FieldHolder.
>
> "will set FieldHolder" is a bit confusing. It creates the FieldHolder and sets the field "holder" so I think the comment could be a bit clearer.
Thanks for looking at this @AlanBateman . I have updated the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13287#discussion_r1155715351
More information about the build-dev
mailing list