RFR: 8305425: Thread.isAlive0 doesn't need to call into the VM [v6]

David Holmes dholmes at openjdk.org
Wed Apr 5 04:41:07 UTC 2023


On Wed, 5 Apr 2023 02:30:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> We have the strange situation where calling `t.isAlive()` on a `java.lang.Thread` `t`, will call into the VM (via `alive()` then `isAlive0()`) where the VM then examines the `eetop` field of `t` to extract its `JavaThread` pointer and compare it to null. We can simply read `eetop` directly in `Thread.alive()`:
>> 
>> boolean alive() {
>>   return eetop != 0;
>> } 
>> 
>> I also updated a comment in relation to `eetop`.
>> 
>> Testing: tiers 1-3
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Switch from using synchronized to using a volatile eetop field
>  - Added Shipilev's test (with a small addition)

Thanks for looking at this @Exe-Boss

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13287#issuecomment-1496907094



More information about the build-dev mailing list