RFR: 8304915: Create jdk.internal.util.Architecture enum and apply

Glavo duke at openjdk.org
Wed Apr 5 17:41:04 UTC 2023


On Wed, 5 Apr 2023 17:15:13 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Yes, the capitalization names should be disciplined. In the enum, there are all uppercase, following the style of manifest constants and enums. In the build they are always lower case. Camel case is usually used for method names. Using all upper case would make them consistent with the Enum names.

What I mean is, should we rename these methods? Because they are really ugly.

https://github.com/openjdk/jdk/blob/0c61382dc50fdc66d3e2b9a9975ac31d91890a5e/src/java.base/share/classes/jdk/internal/util/Architecture.java#L91

https://github.com/openjdk/jdk/blob/0c61382dc50fdc66d3e2b9a9975ac31d91890a5e/src/java.base/share/classes/jdk/internal/util/Architecture.java#L105

https://github.com/openjdk/jdk/blob/0c61382dc50fdc66d3e2b9a9975ac31d91890a5e/src/java.base/share/classes/jdk/internal/util/Architecture.java#L112

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13357#discussion_r1158823225



More information about the build-dev mailing list